.

This post has been edited by Phantom_of_the_opera: 3 May, 2007 - 10:41 AM

What is the exact error your are given? If you specify void in your functions then there is not need to use a return statement. Void means you are not returning any value. Also from taking a quick look at your code it looks like your are not returning any value just declaring if they are married and have kids.

for a start to you don't pass the information between the functions correctly, i.e. you assign gROSS2= Gross and PAID = paidPentrybefore you call getData()
try

.

This post has been edited by Phantom_of_the_opera: 3 May, 2007 - 10:41 AM

Perhaps I'm missing something...

In the code above, you assign Percent a value of 0, then assign TAXABLE the value of percent, which is 0. You don;t appear to change the value of TAXABLE.so it is always 0 in the function. It does not appear to get caught in any of your if statements, so it is never used to calculate Final. This means that Final will hold the same value you passed to the function in the first place, which is 0.

I may have missed something - can you explain each step your function is meant to take?

It may also be worth noting that the following comparison may not work the way you want it to:

This says if TAXABLE is grater than 0 OR Less than or equal to 15000...any value greater than 0 will be caught by this, whereas I suspect you may have wanted an AND condition - meaning that value has to be between the two.

The same is true of your other multiple comparison.

.

This post has been edited by Phantom_of_the_opera: 3 May, 2007 - 10:41 AM

If you did the modifications in my last post you should be passing data from getData() to taxAmount(). You need to check the logic in taxAmount() - note the point that Amadeus made about TAXABLE being 0 so you never calculate Final. I suggest you put some print statements (using cout <<) in taxAmount() so you can see what is the state of variables at each point. You can then see if the values are what you would expect.

.

This post has been edited by Phantom_of_the_opera: 3 May, 2007 - 10:41 AM

Merged topics for continuity. Please do not create multiple topics.

Please describe the problem as best you can and include any error messages or descriptions of what your output is currently compared to with what you are expecting it should be.

.

This post has been edited by Phantom_of_the_opera: 3 May, 2007 - 10:42 AM

TAXABLE >= 15001 && TAXABLE <=40000)
pretty sure this should be an or || since the same variable can never be both of those values at once.

*Any change of working in a case of if(name.equals("William Wilson")) { return "tax exempt!"; } ? lol

Actually using the AND operand is correct. If you use the OR operand then as long as the first condition is true, it will never evaluate the second condition.


@Phantom_of_the_opera
In your taxAmount method the only place that you assign a value to Final is here:


What happens if TAXABLE is 15001 at this point?

Your code enters the first IF statement because it evaluates to true. The first thing you do is put a value in Total equal to (15001 - 2250) = 12751, you then output the value of Total and then enter another IF statement if(Total >15000). Since total is currently 12751 this statement will evaluate to false. The next IF statement will also evaluate to false, if(TAXABLE > 40000). At this point Final has never been assigned a value and as such still has its default value of 0.

I think your second IF statement does not take into account the subtraction of 2250 in the beginning after the first IF statement. Perhaps it should be if(Total >12751).

On a side note, is it possible that TAXABLE can be a value greater 15001 or less then 40000?

If this is the case, it is possible you never get past the first IF statement.