Your if then else logic may not be what you think it is. It currently looks like this:
CODE
while(ch=='y') {
if(a==1) {
} else {
if(a==3) {
} else {
if(a==2) {
} else {
if(a==4) {
} else {
}
}
}
}
}
You probably want it like this:
CODE
while(ch=='y') {
if(a==1) {
} else if(a==3) {
} else if(a==2) {
} else if(a==4) {
} else {
}
}
While its basically the same, the second convention is easier to maintain.
Now, just for functions sake, you do the following three times:
CODE
printf("\n\n ENTER 1ST NUMBER\t>>>>");
scanf("\n %d",b);
printf("\n\n ENTER 2ND NUMBER\t>>>>");
scanf("\n%d",c);
If you were to make a function for that, your code might be easier to read. Functions can also make code blocks easier to follow for non repetitive tasks. Here's my version of your code:
CODE
#include <stdio.h>
#include <stdlib.h>
int menu() {
int a;
printf("\n\n\n\t\t FEDERAL URDU UNIVERSTY");
printf("\n\t\t/*/*/*/*/*/*/*/*/* MAIN MENUE/*/*/*/*/*/*/*/*/*/*/");
printf("\n\n\t PRESS 1 FOR ADDITION",a);
printf("\n\n\t PRESS 2 FOR SUBTRACTION",a);
printf("\n\n\t PRESS 3 FOR MULTIPLICATION",a);
printf("\n\n\t PRESS 4 FOR DIVISION",a);
printf("\n\n\t PRESS 5 FOR MAIN MENUE",a);
printf("\n\n\n\t ENTER UR CHOICE\t>>>>",a);
scanf("%d",&a);
return a;
}
void getNumbers(unsigned int *b, unsigned int *c) {
printf("\n\n ENTER 1ST NUMBER\t>>>>");
scanf("\n %d",b);
printf("\n\n ENTER 2ND NUMBER\t>>>>");
scanf("\n%d",c);
}
main() {
int a;
unsigned int b,c,total;
int d,e;
float tot;
char ch='y';
while(ch=='y') {
a = menu();
if(a==1) {
printf("\n\n\t!**********U CHOSE THE ADDITION*********!");
getNumbers(&b, &c);
total=b+c;
printf("\n\nREAULT=>\t%d+%d=%d",b,c,total);
} else if(a==3) {
printf("\n\n\t!***************** U CHOSE THE MULTIPLICATION*****************");
getNumbers(&b, &c);
total=b*c;
printf("\n\n RESULT=>\t%d*%d=%d",b,c,total);
} else if(a==2) {
printf("\n\n\t!**************** U CHOSE THE SUBTRACTION*****************!");
getNumbers(&b, &c);
total=b-c;
printf("\n\n RESULT=>\t%d-%d=%d",b,c,total);
} else if(a==4) {
printf("\n\n\t!**************U CHOSE THE DIVISION****************!");
printf("\n\n ENTER 1ST NUMBER>>>\t");
scanf(" %d",&d);
printf("\n\n ENTER 2ND NUMBER>>>>\t");
scanf("%d",&e);
tot=(float)d / (float)e;
printf("\n\n RESULT=>\t%d/%d=%f",d,e,tot);
}
printf("\n ----------");
printf("\n\n\n\t\t DO U WANT TO CONTINUE(Y/N)");
scanf(" %c", &ch );
}
return 0;
}
Hope this helps.
| 