well you had many things wrong with this and hopefully the changes I have made for you will help push you in the right direction. First of all, I took out all the statements which are not exactly standard to C++. Next I had to pull out your declaration and put it at the top then modify it to match the signature of your function you defined below (you had it as void when it should have been int to match). I also made the first two parameters const integers passed by value. You don't and shouldn't pass by reference on these since they are not modified in any way during the execution of opt().
I also made a few modifications in opt so that your variables will have proper scope, initialized "f" before passing it to opt() otherwise it would have a null and not work. Modified a few of your statements to now include endline statements. Broke the program a little to show it a little better. Plus a few other things.
The code is below...
CODE
#include <iostream>
#include <conio.h>
#include <process.h>
using namespace std;
// Notice declaration outside of main and matches signature of function below.
// It needs to return int to match what you defined.
// The first two parameters don't need to be passed by reference since they are not modified.
int opt(const int, const int, int &);
void main()
{
char ch;
// Main menu items display
cout << "M A I N M E N U " << endl;
cout << "FIBONACCI SERIES.......................1" << endl;
cout << "SUM OF THE DIGITS ENTERED..............2" << endl;
cout << "ASCII CODE OF THE ENTERED CHARACTER....3" << endl;
cout << "EXIT...................................4" << endl;
// Get the user's input and show them their choice.
cout << "\n\n\n\nEnter yout choice....";
ch = getche();
cout << "\nThe entered choice is......" << ch;
switch (ch)
{
case '1':
int z,f = 0;
// Prompt for the number to show the series up to
cout << "\nFIBONACCI SERIES...";
cout << "\nEnter an integer upto which the series is to be displayed...";
cin >> z;
// Show the series and then opt will return the next value in the series
int y = opt(1,z,f);
cout << "\nNext in the series is..." << y << endl;
break;
}
}
// Displays the fibonacci series and returns the next value in the series.
int opt (const int ch, const int x, int &f)
{
int f1=0, f2=1;
switch (ch)
{
case 1:
while (f<=x)
{
cout << f << " ";
f1=f2, f2=f;
f=f1+f2;
}
}
return f;
}
So read some of the in code comments I put and take a look at the changes. You should see the result as a list of the fibonacci series and then the next value in the sequence returned. I hope this makes some sense and enjoy!
"At DIC we be fibonacci series wielding code ninjas!"
!!!!
| 